Performance Improvement on the Airtable Interface(#1299) #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 90f0551.
|
Thanks @Abellegese |
|
Yes @miquelduranfrigola, on the first pull that you merged, I improve 120,000x time the json based model searching functions so this one is just an alternative. Thanks. |
|
@DhanshreeA let's merge this (or whatever further development you've done) as soon as all is ready. |
DhanshreeA
requested changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
A few improvement made on the airtable interface as listed below:
Changing manual yield with more efficient and auto sub-generator creator yield from
In terms of performance, yield from can be more efficient than manually using yield with a loop. This is because yield from is implemented in C and optimized to handle delegation more efficiently and also has memory improvement. Will report time comparison on the 🐕 Batch: Ersilia CLI Performance Improvement #1299.
Using pyairtable is inevitable so instead of installing it during AirtableInterface call, we can install it as requirements(in pyproject.toml), that reduce the AirtableInterface overhead.
Related to #1299